-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Use new Media Details #55
Comments
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
DTO structure is kept the same for compatibility, previous methods are marked deprecated closes #55
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
DTO structure is kept the same for compatibility, previous methods are marked deprecated closes #55
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
BenShelton
added a commit
that referenced
this issue
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Packages
All
Describe the solution you'd like
Media details used to all be stored in the catalog. Now though they are in a separate NDJSON file, so newer videos no longer have associated media (see #53)
We should transition the
getMediaDetails
to be based off this NDJSON file instead, in a new method, although the DTO can stay the same I believe.Describe alternatives you've considered
Placeholders were added in #54, but we have no title or image so it's unclear what the video is.
Additional context
Endpoint is https://app.jw-cdn.org/catalogs/media/E.json.gz (adjusting for language I assume, untested)
The text was updated successfully, but these errors were encountered: