Skip to content

Commit

Permalink
fix(app-bar): title not hiding completely (ReVanced#1376)
Browse files Browse the repository at this point in the history
  • Loading branch information
TheAabedKhan authored Oct 15, 2023
1 parent 2dc92e2 commit d577e97
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 30 deletions.
8 changes: 3 additions & 5 deletions lib/ui/views/app_selector/app_selector_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,11 @@ class _AppSelectorViewState extends State<AppSelectorView> {
floating: true,
title: I18nText(
'appSelectorView.viewTitle',
child: Text(
'',
style: TextStyle(
),
titleTextStyle: TextStyle(
fontSize: 22.0,
color: Theme.of(context).textTheme.titleLarge!.color,
),
),
),
leading: IconButton(
icon: Icon(
Icons.arrow_back,
Expand Down
45 changes: 20 additions & 25 deletions lib/ui/views/patches_selector/patches_selector_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
floating: true,
title: I18nText(
'patchesSelectorView.viewTitle',
child: Text(
'',
style: TextStyle(
color: Theme.of(context).textTheme.titleLarge!.color,
),
),
),
titleTextStyle: TextStyle(
fontSize: 22.0,
color: Theme.of(context).textTheme.titleLarge!.color,
),
leading: IconButton(
icon: Icon(
Expand All @@ -80,24 +78,19 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
},
),
actions: [
FittedBox(
fit: BoxFit.scaleDown,
child: Container(
margin: const EdgeInsets.only(top: 12, bottom: 12),
padding:
const EdgeInsets.symmetric(horizontal: 6, vertical: 6),
decoration: BoxDecoration(
color: Theme.of(context)
.colorScheme
.tertiary
.withOpacity(0.5),
borderRadius: BorderRadius.circular(6),
),
child: Text(
model.patchesVersion!,
style: TextStyle(
color: Theme.of(context).textTheme.titleLarge!.color,
),
Container(
margin: const EdgeInsets.symmetric(vertical: 12),
padding: const EdgeInsets.symmetric(horizontal: 6),
decoration: BoxDecoration(
color:
Theme.of(context).colorScheme.tertiary.withOpacity(0.5),
borderRadius: BorderRadius.circular(6),
),
alignment: Alignment.center,
child: Text(
model.patchesVersion!,
style: TextStyle(
color: Theme.of(context).textTheme.titleLarge!.color,
),
),
),
Expand Down Expand Up @@ -294,7 +287,9 @@ class _PatchesSelectorViewState extends State<PatchesSelectorView> {
_managerAPI.isPatchesChangeEnabled(),
hasUnsupportedPatchOption:
hasUnsupportedRequiredOption(
patch.options, patch),
patch.options,
patch,
),
options: patch.options,
isSelected: model.isSelected(patch),
navigateToOptions: (options) =>
Expand Down

0 comments on commit d577e97

Please sign in to comment.