Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for *-pc-windows-gnullvm targets #23

Merged

Conversation

AlexTMjugador
Copy link
Contributor

These are tier 2 LLVM-based toolchains, so the LLVM prefix for windres should be used. I've tested these changes by compiling a "hello world" executable for the target in a Docker container and everything worked well, as far as I could see.

These are tier 2 LLVM-based toolchains, so the LLVM prefix for windres
should be used. I've tested these changes by compiling a "hello world"
executable for the target in a Docker container and everything worked
well, as far as I could see.
@AlexTMjugador
Copy link
Contributor Author

Fixes #17. Because the *-pc-windows-gnullvm targets lack host tools, it can be assumed that cross-compilation (e.g., the host triple not being equal to the target triple) always happens.

@BenjaminRi BenjaminRi merged commit e40f2bc into BenjaminRi:master Nov 27, 2024
@BenjaminRi
Copy link
Owner

Looks good to me. Thank you.

@ognevny
Copy link

ognevny commented Nov 27, 2024

it can be assumed that cross-compilation (e.g., the host triple not being equal to the target triple) always happens.

fyi, in MSYS2 all CLANG* environments use *-gnullvm host and target

@BenjaminRi
Copy link
Owner

The submitted change is still guarded by a check that we are cross-compiling. While my tests didn't reveal any breakage, please report related issues here if there are any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants