Better input validation

Fix #261
BenjaminVanRyseghem · Mar 27, 2017 · 02ce326 · 02ce326
1 parent 6c0595e
commit 02ce326
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/numbro.js b/numbro.js
@@ -719,8 +719,10 @@
             input = input.value();
         } else if (input === 0 || typeof input === 'undefined') {
             input = 0;
-        } else if (!Number(input)) {
+        } else if (typeof input === 'string' || typeof input === 'number') {
             input = numbro.fn.unformat(input);
+        } else {
+            throw new Error('Invalid input');
         }
 
         return new Numbro(Number(input));

diff --git a/tests/numbro/format.js b/tests/numbro/format.js
@@ -716,6 +716,18 @@ exports.format = {
       }
 
       test.done();
+    },
+
+	regression261: function(test) {
+		// Setup
+		var currentCulture = numbro.culture();
+
+		numbro.culture("de-DE");
+		var result = numbro("100.000").format();
+		test.strictEqual(result, "100.000");
 
+		//Teardown
+		numbro.culture(currentCulture);
+		test.done();
     }
 };