Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken with eslint 5.13.0 #113

Closed
alexander-akait opened this issue Feb 1, 2019 · 2 comments
Closed

broken with eslint 5.13.0 #113

alexander-akait opened this issue Feb 1, 2019 · 2 comments

Comments

@alexander-akait
Copy link

Description

Setup configuration

  • ESLint version: 5.13.0
  • eslint-plugin-html version: 5.0.0
  • NodeJS version: v10.15.0
  • Operating System name and version: Ubuntu 18.10
  • ESLint configuration (.eslintrc): don't has sense, any
  • Editor name and version: no
  • Plugin name and version: no

Aditional context

TypeError: Cannot read property 'define' of undefined
    at verifyCodePart (/path/to/node_modules/eslint-plugin-html/src/index.js:167:18)
    at verifyWithSharedScopes (/path/to/node_modules/eslint-plugin-html/src/index.js:215:5)
    at Linter.verify (/path/to/node_modules/eslint-plugin-html/src/index.js:201:7)
    at Linter.verifyAndFix (/path/to/node_modules/eslint/lib/linter.js:1032:29)
    at processText (/path/to/node_modules/eslint/lib/cli-engine.js:197:32)
    at processFile (/path/to/node_modules/eslint/lib/cli-engine.js:241:12)
    at fileList.map.fileInfo (/path/to/node_modules/eslint/lib/cli-engine.js:613:40)
    at Array.map (<anonymous>)
    at CLIEngine.executeOnFiles (/path/to/node_modules/eslint/lib/cli-engine.js:585:34)
    at Object.execute (/path/to/node_modules/eslint/lib/cli.js:197:111)
@not-an-aardvark not-an-aardvark mentioned this issue Feb 1, 2019
Closed
@ggetz ggetz mentioned this issue Feb 1, 2019
Closed
@plinss
Copy link

plinss commented Feb 1, 2019

See also: eslint/eslint#11346 (comment)

@simonbrunel simonbrunel mentioned this issue Feb 2, 2019
Closed
@BenoitZugmeyer
Copy link
Owner

Thank you for the report. Fixed in eslint-plugin-html 5.0.1.

rkaravia pushed a commit to imhofjs/leaflet-providers that referenced this issue Feb 3, 2019
@rzoller
Update eslint-plugin-html
020208b 
This fixes the following error:
   TypeError: Cannot read property 'define' of undefined
See BenoitZugmeyer/eslint-plugin-html#113

+ add node_modules to .gitignore
jieter pushed a commit to leaflet-extras/leaflet-providers that referenced this issue Feb 6, 2019
@rzoller @jieter
Tile attribution improvements (#309)
29fcb51 
* Improve OSM attribution

- Use "(c) OpenStreetMap contributors" instead of "(c) OpenStreetMap"
  as suggested on https://www.openstreetmap.org/copyright
- Use https URL

* Update HOTOSM attribution

Use the same attribution as openstreetmap.org for the HOT tiles.

* Update Mapbox attribution

See https://docs.mapbox.com/help/how-mapbox-works/attribution/#text-attribution

* Update eslint-plugin-html

This fixes the following error:
   TypeError: Cannot read property 'define' of undefined
See BenoitZugmeyer/eslint-plugin-html#113

+ add node_modules to .gitignore
@Haprog Haprog mentioned this issue Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BenoitZugmeyer @plinss @alexander-akait