Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking block flag don't allow user to "punch" crates if these are skulls #1809

Closed
Malachiel87 opened this issue Jun 29, 2021 · 4 comments
Closed
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@Malachiel87
Copy link

Description

Describe the bug

Creating crates with the plugin crate reloaded, that allow crates to be inspected by "punching" them, it work only if the crates are not skulls, for blocks and chest work fine. Using 1.17 paper and plugin PRO Crate reloaded https://www.spigotmc.org/resources/pro-crate-reloaded-mystery-crate-1-8-1-17-x.3663/updates

Steps to reproduce the behavior

  1. place a crate as skull item, punch it, it trigger the breaking block flag instead open the gui, doing that with blocks work fine instead

Expected behavior

it should work also for crates, crates developers tell me that bskyblock is not cancelling the break blocks event but the interact action

@BONNe
Copy link
Member

BONNe commented Jun 29, 2021

@tastybento
Copy link
Member

This code was to protect against breaking of skulls placed on an island. It's very old though and maybe the exploit or bug that it protected against no longer exists. We can take it out as an experiment.

@Malachiel87
Copy link
Author

When you will implement this?

@tastybento tastybento self-assigned this Jul 24, 2021
@tastybento tastybento transferred this issue from BentoBoxWorld/BSkyBlock Jul 24, 2021
@tastybento tastybento added the Status: In progress Working on the issue. label Jul 24, 2021
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jul 24, 2021
@tastybento
Copy link
Member

@Malachiel87 Try the latest CI build when it is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

No branches or pull requests

3 participants