Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't turn obsidian into a magma barrel #1683

Closed
CornWorld opened this issue Feb 15, 2021 · 7 comments
Closed

Can't turn obsidian into a magma barrel #1683

CornWorld opened this issue Feb 15, 2021 · 7 comments
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.16.0 - Home swe...

Comments

@CornWorld
Copy link

You can see this situation below

Minecraft_.1.16.5.-.2021-02-15.12-32-37.mp4

I used a bucket to right click the obsidian and then nothing happened but the prompt was successful
@tastybento
Copy link
Member

Share your /bbox version so we know what version you are using.

@tastybento tastybento added the Status: Need answer Waiting for more information to be provided by the issue's author. label Feb 15, 2021
@CornWorld
Copy link
Author

All right
here you are
bbox version

@tastybento tastybento self-assigned this Feb 15, 2021
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. Type: Bug and removed Status: Need answer Waiting for more information to be provided by the issue's author. labels Feb 15, 2021
tastybento added a commit that referenced this issue Feb 15, 2021
@tastybento
Obsidian scooping was weird with just one bucket.
fb4ad90 
It's not clear why this was flakey. It might be that the event was being
canceled.

#1683
@tastybento
Copy link
Member

tastybento commented Feb 15, 2021 •
edited
Loading

I saw a different issue on my machine. I think it's a race condition. I changed the code to make it better. Please try the latest BentoBox build when it is finished and let me know if it works for you: https://ci.codemc.io/job/BentoBoxWorld/job/BentoBox/1980/
NOTE: This is a pre-release snapshot, so take backups before using. I recommend you try on a test server.

@CornWorld
Copy link
Author

Oh, I tried it but didn't look better
(
And here is /bbox version's result
image
)

@CornWorld
Copy link
Author

And I am interested in what you see on your machine (●'◡'●)

@tastybento
Copy link
Member

There is something not right if there is water by the block. If it's air, I have no issues anytime. I'll try and upload a video when I can. I need to see if I can fix the water issue.

tastybento added a commit that referenced this issue Feb 15, 2021
@tastybento
Improves obsidian scooping in presence of water.
14592ec 
#1683
@tastybento
Copy link
Member

I changed some of the code and it seems to work better now. This is surprisingly difficult and I think part of it may be a server bug of some kind. Anyway, here's the video:
https://user-images.githubusercontent.com/4407265/108002998-21f6aa80-6fa6-11eb-99d5-d03adec4814a.mov

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.16.0 - Home sweet home...
Development

No branches or pull requests
2 participants
@tastybento @CornWorld