Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File creation WARN #2259

Closed
SlimeDog opened this issue Jan 4, 2024 · 4 comments · Fixed by #2260
Closed

File creation WARN #2259

SlimeDog opened this issue Jan 4, 2024 · 4 comments · Fixed by #2260

Comments

@SlimeDog
Copy link

SlimeDog commented Jan 4, 2024

Expected behavior

Clean start-up

Observed/Actual behavior

After initial creation of panels, on subsequent start-ups

[10:05:52] [Server thread/WARN]: [BentoBox] Could not save island_creation_panel.yml to plugins/BentoBox/panels/island_creation_panel.yml because island_creation_panel.yml already exists.
[10:05:52] [Server thread/WARN]: [BentoBox] Could not save language_panel.yml to plugins/BentoBox/panels/language_panel.yml because language_panel.yml already exists.

Steps/models to reproduce

  • Install BentoBox 2.0.0-b2519
  • Start server
  • Stop server
  • Start server
  • Read WARN messages

BentoBox version

> bbox version
[10:10:15 INFO]: Running  PAPER 1.20.4 .
[10:10:15 INFO]: BentoBox version:  2.0.0-SNAPSHOT-b2519
[10:10:15 INFO]: Database:  JSON
[10:10:15 INFO]: Loaded Game Worlds:
[10:10:15 INFO]: world_skyblock  ( SkyBlock ):  Overworld, Nether, The End
[10:10:15 INFO]: Loaded Addons:
[10:10:15 INFO]: Biomes  2.2.0-SNAPSHOT-b256  ( ENABLED )
[10:10:15 INFO]: BSkyBlock  1.17.0-SNAPSHOT-b751  ( ENABLED )
[10:10:15 INFO]: Challenges  1.3.0-SNAPSHOT-b539  ( ENABLED )
[10:10:15 INFO]: ExtraMobs  1.12  ( ENABLED )
[10:10:15 INFO]: Level  2.12.0-SNAPSHOT-b555  ( ENABLED )

Plugin list

Irrelevant

Other

No response

@BONNe
Copy link
Member

BONNe commented Jan 4, 2024

Yes it is expected to have this warning
All custom GUIs must be updated with a new spigot potion types

@SlimeDog
Copy link
Author

SlimeDog commented Jan 4, 2024

That isn't what the WARN messages say; they say that BentoBox is unable to create the two panels, because they already exist (these panels were introduced in the latest build).

What do we need to do to correct the potion types, or otherwise resolve the WARN messages?

@BONNe
Copy link
Member

BONNe commented Jan 5, 2024

I am very sorry. I did not read the warning message but assumed it was about item parsing.
Yes, I fix this message.

BONNe added a commit that referenced this issue Jan 5, 2024
Spigot JavaPlugin#saveResources either replaces or complains that replacement is disabled. So it is necessary to check if file does not exists before saving it.

Fixes #2259
BONNe added a commit that referenced this issue Jan 5, 2024
Spigot JavaPlugin#saveResources either replaces or complains that replacement is disabled. So it is necessary to check if file does not exists before saving it.

Fixes #2259
@SlimeDog
Copy link
Author

SlimeDog commented Jan 7, 2024

Confirmed fixed in b2521. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants