Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request confirmation when /is sethome is used while being in the Nether/End #237

Closed
8 tasks done
Poslovitch opened this issue Aug 15, 2018 · 3 comments
Closed
8 tasks done
Assignees
Labels
Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@Poslovitch
Copy link
Member

Poslovitch commented Aug 15, 2018

Is your feature request related to a problem? Please describe.
People can get stuck in the Nether or in the End if they do /is sethome there.

Describe the solution you'd like
A confirmation should be requested if the player executes this command while not being in the Overworld.

TODO List

  • Make command to be confirmable
  • Add requireConfirmationToSetHomeInNether and requireConfirmationToSetHomeInTheEnd in WorldSettings
  • Update command accordingly
  • Add texts to explain the confirmation request
  • Add allowSetHomeInNether and allowSetHomeInTheEnd in WorldSettings
  • Make the command use these two new settings
  • Test the tests
  • Commit&push
@Poslovitch Poslovitch added the Type: Enhancement Improvement or modification which is usually a new feature. label Aug 15, 2018
@TheWranger
Copy link

Perhaps there could also be an option in the configuration to block players from setting their main home there? Would be useful for if a server doesn't want to risk being bothered by some of their players asking staff members to move their home.

@robert-beckley
Copy link

I would also like to see this added.

@Poslovitch Poslovitch self-assigned this Oct 20, 2018
Poslovitch added a commit that referenced this issue Oct 25, 2018
#237

It adds a bunch of WorldSettings and updates the en-US locale as well!
@Poslovitch
Copy link
Member Author

Done! Will be released in Alpha 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants