Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boat & Minecart island settings #387

Closed
TheWranger opened this issue Dec 16, 2018 · 11 comments
Closed

Boat & Minecart island settings #387

TheWranger opened this issue Dec 16, 2018 · 11 comments
Assignees
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Milestone

Comments

@TheWranger
Copy link

Is your feature request related to a problem? Please describe.
There's currently no way for island owners to directly control who can ride and interact with boats and minecarts.

Describe the solution you'd like
An island setting to control who can ride in boats and an island setting to control who can ride in minecarts. The settings should not affect users who enter the island while riding these entities.

Describe alternatives you've considered
Haven't considered any alternatives.

@tastybento
Copy link
Member

Why? There's no damage done in either case, is there?

@tastybento tastybento added the Status: Need answer Waiting for more information to be provided by the issue's author. label Dec 16, 2018
@TheWranger
Copy link
Author

An example could be that maybe a player wants to host a boat race (with selected people) or something on their island for fun, the owner has no easy way and simple of way of just allowing co-oped players and above to ride boats.

@tastybento
Copy link
Member

Sound fun - boat races.

This is one of those flags (rare) that I don't want to enable on AcidIsland though because then players could lose their boat.

Also, preventing entry is okay, but no ejection if you are already in. Again it could be nasty on acid island.

@tastybento tastybento added Type: Enhancement Improvement or modification which is usually a new feature. and removed Status: Need answer Waiting for more information to be provided by the issue's author. labels Dec 16, 2018
@TheWranger
Copy link
Author

Not ejecting players if they were already in was sorta the idea I was going for anyway.
Couldn't you still allow this on AcidIsland but add a note in the config about this, saying that it's recommended that they don't allow players to change the setting?

@TheWranger
Copy link
Author

Also, I think minecarts and boats should be separate settings because:

  1. Then island owners can manage minecarts without it affecting boats in AcidIsland.
  2. Island owners can manage who can access their rollercoaster rides without it affecting boats as well.

@tastybento
Copy link
Member

I'm thinking of maybe having a way for add-ons to hide flags that are not appropriate. Or maybe even add them independently of the standard set. This may be something that we add to BSkyBlock as a BSkyBlock-specific flag. Hmm, I'll have to think about the best way to do this. Any thoughts @Poslovitch ? What do you think about add-ons registering their own flags and those flags only being visible in that world? I think we have the basic structure there to do that, right? We'd just need filtering on the Settings panel to only show general flags and ones specific to that world.

@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Dec 16, 2018
@Poslovitch
Copy link
Member

Hmmm...
Basically, that's what the Flags API was designed to do. Addons can register Flags, however they become global to the entire BentoBox "network". That shouldn't be too much of a struggle to add a way to actually only register them to a specific gamemode, but then that would maybe have to wait for the "World management" rework to be done first (as it features things like Gamemode, GameWorlds, etc...)

@Poslovitch Poslovitch removed the Status: Under investigation Investigating the interest and the feasability of the issue. label Feb 2, 2019
@Poslovitch Poslovitch added this to the 1.3.0 milestone Feb 2, 2019
@tastybento
Copy link
Member

Depends on #406

Poslovitch added a commit that referenced this issue Feb 10, 2019
Poslovitch added a commit that referenced this issue Feb 10, 2019
@TheWranger
Copy link
Author

I think that chest minecarts and furnace minecarts should be controlled by the furnace and chest protection settings, if they aren't already.

@Poslovitch Poslovitch self-assigned this Feb 11, 2019
@Poslovitch
Copy link
Member

@TheWranger Could you please create another ticket for that?

@TheWranger
Copy link
Author

I think it sorta relates to #529, but that ticket had poor information in it so I'll make one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants