Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/bsbadmin commands not functioning properly #506

Closed
wellnesscookie opened this issue Jan 31, 2019 · 3 comments
Closed

/bsbadmin commands not functioning properly #506

wellnesscookie opened this issue Jan 31, 2019 · 3 comments
Assignees
Milestone

Comments

@wellnesscookie
Copy link
Contributor

wellnesscookie commented Jan 31, 2019

Description
After the island & owner are registered via /bsbadmin register - /bsbadmin setowner,kick & /is team kick,setowner seem to act irregulary. Only the latest problem with spawn island will be explained below, since it's fresh, though it happens with other too.

Steps to reproduce the behavior:

  1. We updated to the plugin version which has /bsbadmin setspawn implemented. The island that you will see on the pictures had earlier been registered to one of our staff members, as then no option existed to set the spawn island. The island became unregistered (Not sure when), but also recognized as spawn on /bsbadmin info. We are not quite sure if the setspawn command unregistered it or was the spawn island caught within the bugged ones on issue: Duplicate islands in database #505 .
  2. Since we needed to change some Island Seettings due to usage of anvils for visitors on spawn island, we needed an owner to do it. As it was unregistered, we used /bsbadmin register 'acBee' in order for him to change them. *acBee was able to edit settings, which you may find interesting later.
  3. Player 'acBee' was registered with the command above, and player 'Batica' was added to it via /bsbadmin add acBee Batica. You can see the information given from /bsbadmin info on this picture after previous steps: https://i.imgur.com/pTAvuoe.png.
  4. We wanted to make 'Batica' the island owner, so we used /bsbadmin setowner Batica, but we received ~'That player is not in your team', see picture for: /bsbadmin setowner Batica
  5. When we tried to kick 'Batica' via /bsbadmin kick Batica, next message popped up: ~'You do not have an island'. See picture for: /bsbadmin kick Batica
  6. Since 'acBee' (me) was the owner, I also tried /island team kick Batica, and it spoke 'Success!'
  7. /bsbadmin info was still showing Batica as a member. We were still able to reAdd Batica to the island using /bsbadmin add acBee Batica with positive output in chat. At that point we weren't anymore sure who's there and who ain't. :)
  8. Try usage of /is team setowner as replacement for /bsbadmin one, sent a message in chat: "An internal error occurred while attempting to perform this command."

Expected behavior
The usage of /bsbadmin and /island above mentioned commands should have a different outcome?

Server Information:

  • Database being used:
    MySQL

  • OS:
    Debian GNU/Linux 9

  • Java Version:
    Java(TM) SE Runtime Environment 18.3 (build 10.0.1+10)
    Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.1+10, mixed mode)

  • Addons installed?
    [23:30:32] [main/INFO]: [CHAT] Bentobox version: 1.2.1-SNAPSHOT
    [23:30:32] [main/INFO]: [CHAT] Loaded Game Worlds:
    [23:30:32] [main/INFO]: [CHAT] skyblock (skyblock)
    [23:30:32] [main/INFO]: [CHAT] Loaded Add-Ons
    [23:30:32] [main/INFO]: [CHAT] BSkyBlock 1.2.0
    [23:30:32] [main/INFO]: [CHAT] Biomes 0.4.1
    [23:30:32] [main/INFO]: [CHAT] ASBwarp 1.0
    [23:30:32] [main/INFO]: [CHAT] Challenges 0.3.1-SNAPSHOT
    [23:30:32] [main/INFO]: [CHAT] WelcomeWarps 1.1-SNAPSHOT
    [23:30:32] [main/INFO]: [CHAT] Level 1.1-SNAPSHOT

  • Other plugins?
    [06:32:17 INFO]: Plugins (50): AnimatedNames*, AreaShop, ArmorStandTools, BentoBox, BungeeTabListPlus*, ChatControl, ChestCommands, ChestShop*, ClearLag*, CrateReloaded, EditableSign, Essentials, EssentialsChat*, EssentialsSpawn*, ExecuteEverywhere*, FastAsyncWorldEdit*, FeatherBoard*, HeadDatabase*, HolographicDisplays, HungerKeeperPlus*, IPWhitelist*, IslandBorder, LeaderHeads*, LibsDisguises, LuckPerms, MobManager*, Multiverse-Core*, MVdWPlaceholderAPI*, NickRemover*, NoSleepCMDs*, OpenInv*, PlayerHeads, PlayerPoints*, ProtocolLib*, PvPManager*, PvPManagerBossBar*, RedstoneClockDetector*, RPGHealthIndicator*, SilkSpawners, SkinsRestorer, Spartan, TradeMe, TrophyHeads*, UnbreakingAnvils*, Vault*, VoidGenerator, WorldEdit, WorldGuard, WorldGuardPistonFix*, Yamler*

Additional context
*Necessary translations for feedback from commands are provided on the pictures.
*All bsbadmin and player side commands were executed as player 'acBee'
*Batica was offline all the time during these command executions.
*We think it has nothing to do with the island being a spawn one, since it's not the first time we are experiencing weird problems with ./bsbadmin commands and not specifically with spawn island.
*Some of the information seem to be refreshed and shown correctly after server restart, which we won't be doing often, since we are having around ~100 players online on skyblock at one moment.

Thanks in advance! :))

@tastybento tastybento self-assigned this Jan 31, 2019
@tastybento
Copy link
Member

Player was not being added correctly to the island (I was writing to the Island object directly instead of using the Island Manager - duh). You'll need to unregister Batica from the island using the admin unregister command and then re-add him. Note that you will need the new build to unregister a team member. Fix coming in a few mins.

tastybento added a commit that referenced this issue Jan 31, 2019
Fixes #506

Also, admin unregister was blocking unregistration of team players, but
that is an artificial constraint, so I enabled it. Without it, it would
not be possible to correct weird team issues like this one after they
happen.
@tastybento
Copy link
Member

Okay, give the new build a test when you can and if it works for you then close the ticket.

@tastybento tastybento added this to the 1.2.1 milestone Jan 31, 2019
@wellnesscookie
Copy link
Contributor Author

wellnesscookie commented Feb 3, 2019

Sorry for late reply, but we did not update until now.

[main/INFO]: [CHAT] Bentobox version: 1.3.0-SNAPSHOT

-The island was unregistered as you said.
-Registered the island to acBee
-Added Batica via /bsbadmin add
-Did /bsbadmin setowner Batica (Successfully this time, so it's fixed)
-/bsbadmin info was shown properly
-On /bsbadmin kick acBee: "You don't have an island" (Executed as acBee) ?
-Though /is team leave worked, acBee left the island and island information was correct. (Executed as acBee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants