Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to hide Vanished players from Teams #1499

Merged
merged 18 commits into from
Aug 23, 2020
Merged

Added support to hide Vanished players from Teams #1499

merged 18 commits into from
Aug 23, 2020

Conversation

Paul19988
Copy link
Contributor

Added player.CanSee(Player) to check if player is hidden by vanish plugin,
Added custom layout to support hiding offline times for Coop & trusted roles as these roles do not have to be accepted by the recipient.

@Paul19988 Paul19988 mentioned this pull request Aug 22, 2020
Closed
tastybento
tastybento requested changes Aug 22, 2020
View reviewed changes
Copy link
Member

@tastybento tastybento left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Util class method that I'd prefer to be used in here somewhere - Util.getOnlinePlayerList(User user) will provide a list of visible players for that user.

@Paul19988 Paul19988 requested a review from tastybento August 23, 2020 01:36
@Paul19988
Copy link
Contributor Author

Requires re-approval after changes made

@Poslovitch Poslovitch added Status: Need review Waiting for a review to be made on this Pull Request Type: Bug labels Aug 23, 2020
Poslovitch
Poslovitch requested changes Aug 23, 2020
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good intent, and thanks for your work, but I find the changes a bit confusing. I've pinpointed that in my review comments. Have a look at them, please.

src/main/resources/locales/en-US.yml Outdated Show resolved Hide resolved
src/main/java/world/bentobox/bentobox/api/commands/island/team/IslandTeamCommand.java Outdated Show resolved Hide resolved
@Paul19988 Paul19988 requested a review from Poslovitch August 23, 2020 15:56
Poslovitch
Poslovitch approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!
Thanks for your quick changes.

@tastybento Please review, and I'll merge the changes.

@Poslovitch Poslovitch linked an issue Aug 23, 2020 that may be closed by this pull request
Various commands can expose vanished players #972
Closed
tastybento
tastybento approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@tastybento tastybento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@tastybento tastybento merged commit 01c2c30 into BentoBoxWorld:develop Aug 23, 2020
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need review Waiting for a review to be made on this Pull Request labels Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tastybento tastybento tastybento approved these changes

@Poslovitch Poslovitch Poslovitch approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.15.0 - Futurus, ad vitam æternam
Development

Successfully merging this pull request may close these issues.

Various commands can expose vanished players
3 participants
@Paul19988 @tastybento @Poslovitch