Persistent entities should never be removed. #1608
Conversation
There is no valid reason why BentoBox should remove the Persistent entity. Otherwise, what is the point of being persistent if someone can just remove it?
|
This change will not remove Pufferfish if someone takes them out of a bucket, or if they rename any hostile entity. But I think it should not do it... Otherwise, if someone creates a peaceful raider or any other hostile entity, they could be removed on teleport... and it is just wrong. Also, GeoLimitMobsListener should be reworked, but adding just a persistence check would include all animals, as they by default are persistent. So if the point of that listener is to include all passive mobs, then it should check for persistence on hostile entities, fishes from a bucket, and all entities with a custom name. |
Protect renamed and persistent entities from being removed if they wander outside island bounds. Except for animals, as they cannot be removed only if they are renamed.
|
Thanks! |
| @@ -1374,7 +1374,8 @@ public void clearArea(Location loc) { | |||
| loc.getWorld().getNearbyEntities(loc, plugin.getSettings().getClearRadius(), | |||
| plugin.getSettings().getClearRadius(), | |||
| plugin.getSettings().getClearRadius()).stream() | |||
| .filter(en -> Util.isHostileEntity(en) | |||
| .filter(en -> !en.isPersistent() | |||
There was a problem hiding this comment.
This caused a regression. By default (per JavaDocs) all entities are persistent. So actually, this is already false.
This reverts commit 0e4b3b4.
There is no valid reason why BentoBox should remove the Persistent entity. Otherwise, what is the point of being persistent if someone can just remove it?