Bbox admin perms command #2141
Merged
Bbox admin perms command #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some admin commands have their own perm so that they can be controlled individually by permissions.
|
|
BONNe
approved these changes
Jun 21, 2023
|
Thanks for the approval. I need to check that the API thing actually works. I was running a test and ran the command in game and it didn’t send the error message saying it was a console only command so I need to check where the bug may be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
bbox permscommand that will output in YAML format the effective perms for all addons and BentoBox itself. This output can be used to update the respective addon.yml's or plugin.yml's. It does not (yet) substitute in [gamemode] but that might be added.The idea is to identify all the permissions that are available so that these can also be shared in documentation so that admins can more effectively manage permissions.
This PR also adds some API to CompositeCommand to enable commands to be console-only. This is similar to the player-only API. The goal of this is to prevent spammy commands designed for console output (mostly debug stuff) to not be used in-game. This is used by the perms command.