Fixes a bug with incorrectly indexed pages +1 #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced by #585f720f6f4a7e9480af5065469c92e23e5a987e which reduced complexity too much. Fixes #2177
|
SonarCloud Quality Gate failed.
|
|
SonarCloud is reporting non-existing failure, as before |
Yes. False positive, I reported it to Sonar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 585f720 broke button creation, as buttons were created before actually knowing how many buttons of the type should be created.
This change returns to the previous button processing, however, I reduced the complexity for all panels, so they are processed the same way.