Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes defaults for pasting entities. Gravity default is true not false #2582

Merged
merged 1 commit into from
Dec 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ public record TextDisplayRec(@Expose String text, @Expose TextAlignment alignmen
@Expose
private double z;
@Expose
private boolean glowing;
private Boolean glowing;
@Expose
private boolean gravity;
private Boolean gravity;
@Expose
private boolean visualFire;
private Boolean visualFire;
@Expose
private boolean silent;
private Boolean silent;
@Expose
private boolean invulnerable;
private Boolean invulnerable;
@Expose
private int fireTicks;

Expand All @@ -149,6 +149,7 @@ public record TextDisplayRec(@Expose String text, @Expose TextAlignment alignmen
* @param entity entity to serialize
* @since 3.2.0
*/
@SuppressWarnings("deprecation")
public BlueprintEntity(Entity entity) {
this.setType(entity.getType());
this.setCustomName(entity.getCustomName());
Expand Down Expand Up @@ -568,6 +569,9 @@ public void storeDisplay(Display disp) {
* @return the glowing
*/
public boolean isGlowing() {
if (glowing == null) {
glowing = false; // Default
}
return glowing;
}

Expand All @@ -582,6 +586,9 @@ public void setGlowing(boolean glowing) {
* @return the gravity
*/
public boolean isGravity() {
if (gravity == null) {
gravity = true;
}
return gravity;
}

Expand All @@ -596,6 +603,9 @@ public void setGravity(boolean gravity) {
* @return the visualFire
*/
public boolean isVisualFire() {
if (visualFire == null) {
visualFire = true;
}
return visualFire;
}

Expand All @@ -610,6 +620,9 @@ public void setVisualFire(boolean visualFire) {
* @return the silent
*/
public boolean isSilent() {
if (silent == null) {
silent = false;
}
return silent;
}

Expand All @@ -624,6 +637,9 @@ public void setSilent(boolean silent) {
* @return the invulnerable
*/
public boolean isInvulnerable() {
if (invulnerable == null) {
invulnerable = false;
}
return invulnerable;
}

Expand Down
Loading