Island delete #466
Island delete #466
Conversation
Island deletion is done a few chunks at a time per tick. Current speed is 5 chunks per tick per world (e.g., 15 chunks per tick if nether and end islands are used). Chunks are deleted based on the all-time maximum protection range of the island. This is because the protection range can grow bigger or smaller over the island's lifetime. To ensure all possible chunks are erased, the largest every protection range is remembered and used. Very large protection ranges will take a long time to fully delete. Info on islands that are being deleted is stored in the database. If the server shuts down mid-deletion, deletion will restart when the server restarts. While an island is being deleted, new islands cannot occupy that spot and the spot cannot be reserved by the admin. In addition, async approaches to island saving and player saving were removed. Async will be implemented another way. Now, instead of saving the full island or player database, individual database entries are saved instead to be more efficient.
Both seem to work fine, but probably need more real-world testing.
src/main/java/world/bentobox/bentobox/database/objects/DeletedIslandDO.java
Outdated
Show resolved
Hide resolved
| } | ||
| Vector location = center.toVector(); | ||
| user.sendMessage("commands.admin.info.island-location", "[xyz]", Util.xyz(location)); | ||
| Vector from = center.toVector().subtract(new Vector(range, 0, range)).setY(0); | ||
| Vector to = center.toVector().add(new Vector(range-1, 0, range-1)).setY(center.getWorld().getMaxHeight()); | ||
| user.sendMessage("commands.admin.info.island-coords", "[xz1]", Util.xyz(from), "[xz2]", Util.xyz(to)); | ||
| user.sendMessage("commands.admin.info.protection-range", "[range]", String.valueOf(protectionRange)); | ||
| user.sendMessage("commands.admin.info.max-protection-range", "[range]", String.valueOf(maxEverProtectionRange)); |
There was a problem hiding this comment.
This might only lead to admins being confused. Why aren't you using the range (island distance) instead?
There was a problem hiding this comment.
Quick answer - using island distance takes too long and is not necessary because only the protection range chunks should need to be deleted.
To avoid admin confusion, I could delete that line 701 and just keep it an internal number.
By the way, I did some experiments with deleting large island ranges running in the background they can take a very long time to delete (minutes), so that's why I wanted to avoid having to regenerate all those chunks. Once 4 or 5 islands were in deletion, the server became very sluggish. So, it's a tradeoff.
There was a problem hiding this comment.
We can make this small change on the main develop branch if required. Let me know what you think.
There was a problem hiding this comment.
Okay, I understand why you didn't use range then. That makes sense.
Then, I'd like to remove line 701. Just to avoid any kind of "support request" that could occur because of that.
src/main/java/world/bentobox/bentobox/managers/IslandDeleteManager.java
Outdated
Show resolved
Hide resolved
|
Overall, the code's good. |
|
Checks failed because I wasn't using the updated pom. Now that it's been merged in develop, that'll be fine. |
|
I'm also adding the MariaDB deletedID method now. Commit in a moment. |
See commit message.
Addresses #457. Should help with #447.