Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds admin commands to handle damaged island db #546

Merged
merged 8 commits into from
Feb 17, 2019
Merged

Conversation

tastybento
Copy link
Member

Trash, purge, etc.

DO NOT MERGE YET

#505

@tastybento tastybento self-assigned this Feb 14, 2019
@tastybento tastybento added the Type: Enhancement Improvement or modification which is usually a new feature. label Feb 14, 2019
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! Give me 5 minutes and I'll merge it.

EDIT: do not worry, that's just a joke ;)

This enables manual removal of old game mode island files from the
database by admins if required.
@tastybento
Copy link
Member Author

Still working on it but getting there.

@tastybento tastybento changed the title WIP - adds admin commands to handle damaged island db Adds admin commands to handle damaged island db Feb 17, 2019
@tastybento
Copy link
Member Author

Okay done. I should still do test classes for these too.

The Game Modes will need corresponding admin commands added to them.
BentoBoxWorld/BSkyBlock#82
BentoBoxWorld/AcidIsland#43

and the other ones too.

@tastybento
Copy link
Member Author

@Poslovitch the tests may not pass because the Vault repo is down. I compiled at home and switched off my WiFi connection to get it done. Anyway, please have a look at the code and merge if you approved. I don't think there's any risk because these are mainly commands.

The only other thing I did which I'm really keen to get into 1.3.0 is that I preface the name of island UUID's with the game mode, which will be useful for admins if they want to delete files or records from databases manually.

@Poslovitch Poslovitch merged commit bce17ce into develop Feb 17, 2019
@Poslovitch Poslovitch deleted the admintrash branch February 17, 2019 12:32
@Poslovitch Poslovitch added this to the 1.3.0 milestone Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants