Permission value can be unlimited

[Kaeios]

Values can be negative to set unlimite like max-bans, ...

[Poslovitch]

I don't understand what the PR's doing. @DarkRails ?

@tastybento Would that actually be an addition? What's the point of the "sanity check" we're doing with the permissions, by the way?

[Kaeios]

in the config you can set a max amount of ban per island & if set to -1. It is supposed to set it to unlimited but the ban limit can also be defined by a permission, the method to get max ban limit for a user is

int banLimit = issuer.getPermissionValue(getPermissionPrefix() + "ban.maxlimit", getIWM().getBanLimit(getWorld()));

default ban limit: -1 (supposed to be unlimited)

but the default value -1 is replaced by 1 by the getPermissionValue method.
So you can ban only one player of your island even if this settings is set to -1 by default

I hope you understand what I mean.

[Poslovitch]

I understand what you mean, however, I'm afraid it may cause bugs. @tastybento, I really need your review on that.

[BONNe]

So,
It will not create bugs...
It will just not work... as with homes :)

Btw... is it even possible to define permission with text permission.value.-1 ?

[tastybento]

This makes sense.

[tastybento]

So, this part is OK, but other places need to be fixed to enable -1 to be valid.

[tastybento]

@BONNe You can specify -1 in a permission, but like you say, this change alone won't work.

The use case is that the ban limit has been set to say 3 in config.yml, but the admin wants to give some players the ability to have unlimited bans. To do that, they would give the permission bskyblock.ban.maxlimit.-1.

This code change won't do it, so I'll fix it.

[tastybento]

@DarkRails Thanks for the tip. In the end I have to do more coding, but now using -1 should work.