Add MINGW cross-compilation support and fix occational windows codepatch issues #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only MSVC has implicit support for this type of conversion
ManlyMarco
approved these changes
Aug 18, 2023
Kasuromi
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the changes in neeetman's PR #2 I had trouble getting the build to work with MSVC.
I had more success cross-compiling using Cygwin and MINGW so I thought that I'd contribute my findings.
Additionally I added my proposed fix to #2 with a simple VirtualProtectEx fallback.
I also found a few pain-points that is more than likely due to not using MSVC:
typedefing standard types (int8_t,int16_t, etc)FARPROC->void *conversion (only supported by MSVC)code-buffer-x64.ccGetProtectionFromMemoryThe first three are probably toolchain related, but the fourth actually made the program not work as memory did not get (un)protected correctly.