Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Cast and PointerToValueGeneric performance #52

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Improve Cast and PointerToValueGeneric performance #52

merged 1 commit into from
Oct 15, 2022

Conversation

js6pak
Copy link
Member

@js6pak js6pak commented Oct 12, 2022

Use a cached DynamicMethod instead reflection for instantiating il2cpp objects.

image

Cursed Unsafe.Ass are required because there is no way to ignore generic constraints and PointerToValueGeneric can return value types.

@js6pak js6pak merged commit 880b9d5 into BepInEx:master Oct 15, 2022
@js6pak js6pak deleted the fix-cast-performance branch October 15, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kasuromi Kasuromi Kasuromi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js6pak @Kasuromi