This repository has been archived by the owner on May 16, 2024. It is now read-only.
Fix parsing of timeDescription while using Family Sharing #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing Apple Card transaction screenshots while using Family Sharing, family member's names are prepended on the date line, which causes the date to be improperly defaulted to "Just now."
This PR attempts to address that by:
timeDescription
contains spaces and is not a relative timestamp and splits after the first space (the family member's name.)TransactionReaderOCRTextTests
to verify that the date parsing changes work.Date+current
andDate+mock
which statically set the date for testing, adapting examples from: https://dev.to/ivanmisuno/deterministic-unit-tests-for-current-date-dependent-code-in-swift-2h72Note: The article also recommends adding a pre-commit hook to verify that
Date()
is no longer used in the code in favor of the newDate.current
which is easier to mock in testing.