Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gfortran in CI with flang-new #200

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

ktras
Copy link
Collaborator

@ktras ktras commented Sep 3, 2024

The docker image being built by developers at NASA that contains LLVM Flang is for Linux architecture, so this PR not only replaces gfortran with flang-new, but also removes the MacOS CI test.

This PR adds gmao/llvm-flang:latest for the docker image, but based on a conversation with the creator of the docker image, it might be updated with different configurations in the future, so in the event that the latest doesn't work in the future, the tag that is associated with the docker image version that works for this repo is gmao/llvm-flang:2024-08-29.

@ktras ktras requested a review from rouson September 3, 2024 21:35
@ktras ktras changed the title Replace gfortran in CI with flang-new Replace gfortran in CI with flang-new Sep 3, 2024
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested one minor change. Otherwise, LGTM.

Co-authored-by: Damian Rouson <rouson@lbl.gov>
@ktras ktras requested a review from rouson September 3, 2024 22:01
Copy link
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit cbf8059 into parameterized-derived-types Sep 3, 2024
4 checks passed
@rouson rouson deleted the support-flang-ci branch September 3, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants