Skip to content

Commit

Permalink
Upgrade upload-artifacts GHA step to v4
Browse files Browse the repository at this point in the history
  • Loading branch information
danschmidt5189 committed Dec 3, 2024
1 parent 868b55c commit 39a3ead
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
16 changes: 4 additions & 12 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
runs-on: ubuntu-latest

container:
options: --init
options: --init --user=root
image: ${{ needs.build.outputs.build_image }}

defaults:
Expand All @@ -90,14 +90,6 @@ jobs:
POSTGRES_USER: root
POSTGRES_PASSWORD: root

# solr:
# image: solr:8
# #restart: always
# ports:
# - 8983:8983
# volumes:
# - ${{ github.workspace }}/solr:/var/solr/data/configsets/solr:delegated

steps:
- name: Run tests
env:
Expand All @@ -106,7 +98,7 @@ jobs:

- name: Run style checks
run: bundle exec rubocop

- name: Validate database migrations
env:
RAILS_ENV: test
Expand All @@ -115,13 +107,13 @@ jobs:

- name: Upload artifacts
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: artifacts
path: |
/opt/app/artifacts/**
/tmp/solr*/server/logs
# TODO: DRY w/release.yml
push:
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ task :check do

require 'solr_wrapper'
Rake::Task[:setup].invoke
SolrWrapper.wrap do |solr|
SolrWrapper.wrap(force: true) do |solr|
solr.with_collection(name: 'geodata-test', dir: "#{Rails.root}/config/solr") do

# Rake::Task[:coverage].invoke
Expand Down

0 comments on commit 39a3ead

Please sign in to comment.