Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rail log through env variable #15

Closed
wants to merge 2 commits into from
Closed

Rail log through env variable #15

wants to merge 2 commits into from

Conversation

yzhoubk
Copy link
Contributor

@yzhoubk yzhoubk commented Mar 12, 2024

No description provided.

@@ -52,7 +52,8 @@

# Include generic and useful information about system operation, but avoid logging too much
# information to avoid inadvertent exposure of personally identifiable information (PII).
config.log_level = :error
config.log_level = ENV.fetch('LOG_LEVEL') { 'info' }.downcase.to_sym
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our Rubocop config will complain about the syntax — it prefers that we write:

ENV.fetch('LOG_LEVEL', 'info').downcase.to_sym

I ran into this as well on my PR. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've not checked Rubocop locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should see a GitHub Actions failure in a few minutes. The STDOUT of the syntax check test will show the error.

@yzhoubk yzhoubk closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants