Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow leaderboard score to fit on one line #524

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

fdoyle
Copy link

@fdoyle fdoyle commented Feb 17, 2016

changed layout name to row_profile for consistency with other list item layouts

set ems to 4 on score textview to guarantee that 4 digits can always safely fit in that space regardless of font (if someone hits a score of 10k, I suppose we'd have to update it again)

@patrickcousins
Copy link
Collaborator

Thanks this. Unfortunately all that extra space makes the design look a bit awkward. Could we try setting the padding/margins/whatever causing space on the left to 0?

@fdoyle
Copy link
Author

fdoyle commented Feb 24, 2016

Improved this a bit. Now 3 ems, but 4 numerical digits seems to fit in that easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants