fix(gemini): append empty choice to model response when there are no … #10186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
|
sonald
force-pushed
the
fix/gemini-empty-choices
branch
from
91b3869 to
0873dfe
Compare
sonald
force-pushed
the
fix/gemini-empty-choices
branch
from
0873dfe to
9ada9b9
Compare
Author
|
@krrishdholakia I have added the test |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
make sure response has at least one choice
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
Type
🐛 Bug Fix
Changes
gemini-2.5-pro-preview-03-25 at some cases will respond with a non-error message that has neither candidates nor promptFeedback, like this:
{ "usageMetadata": { "promptTokenCount": 9291, "totalTokenCount": 9291, "promptTokensDetails": [ { "modality": "TEXT", "tokenCount": 9291 } ] }, "modelVersion": "gemini-2.5-pro-preview-03-25" }this breaks apps like smolagents, this is a related issue on smolagents.