-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Speedup health endpoint #1023
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
set_verbose = False | ||
|
||
def print_verbose(print_statement): | ||
if set_verbose: | ||
print(print_statement) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
import asyncio | ||
import random | ||
from typing import Optional | ||
|
||
import litellm | ||
import logging | ||
from litellm._logging import print_verbose | ||
|
||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
ILLEGAL_DISPLAY_PARAMS = [ | ||
"messages", | ||
"api_key" | ||
] | ||
|
||
|
||
def _get_random_llm_message(): | ||
""" | ||
Get a random message from the LLM. | ||
""" | ||
messages = [ | ||
"Hey how's it going?", | ||
"What's 1 + 1?" | ||
] | ||
|
||
|
||
return [ | ||
{"role": "user", "content": random.choice(messages)} | ||
] | ||
|
||
|
||
def _clean_litellm_params(litellm_params: dict): | ||
""" | ||
Clean the litellm params for display to users. | ||
""" | ||
return {k: v for k, v in litellm_params.items() if k not in ILLEGAL_DISPLAY_PARAMS} | ||
|
||
|
||
async def _perform_health_check(model_list: list): | ||
""" | ||
Perform a health check for each model in the list. | ||
""" | ||
|
||
async def _check_model(model_params: dict): | ||
try: | ||
await litellm.acompletion(**model_params) | ||
except Exception as e: | ||
print_verbose(f"Health check failed for model {model_params['model']}. Error: {e}") | ||
return False | ||
|
||
return True | ||
|
||
prepped_params = [] | ||
|
||
for model in model_list: | ||
litellm_params = model["litellm_params"] | ||
litellm_params["model"] = litellm.utils.remove_model_id(litellm_params["model"]) | ||
litellm_params["messages"] = _get_random_llm_message() | ||
|
||
prepped_params.append(litellm_params) | ||
|
||
|
||
tasks = [_check_model(x) for x in prepped_params] | ||
|
||
results = await asyncio.gather(*tasks) | ||
|
||
healthy_endpoints = [] | ||
unhealthy_endpoints = [] | ||
|
||
for is_healthy, model in zip(results, model_list): | ||
cleaned_litellm_params = _clean_litellm_params(model["litellm_params"]) | ||
|
||
if is_healthy: | ||
healthy_endpoints.append(cleaned_litellm_params) | ||
else: | ||
unhealthy_endpoints.append(cleaned_litellm_params) | ||
|
||
return healthy_endpoints, unhealthy_endpoints | ||
|
||
|
||
|
||
|
||
async def perform_health_check(model_list: list, model: Optional[str] = None): | ||
""" | ||
Perform a health check on the system. | ||
|
||
Returns: | ||
(bool): True if the health check passes, False otherwise. | ||
""" | ||
if not model_list: | ||
return [], [] | ||
|
||
if model is not None: | ||
model_list = [x for x in model_list if x["litellm_params"]["model"] == model] | ||
|
||
models_to_check = [] | ||
|
||
for model in model_list: | ||
litellm_params = model["litellm_params"] | ||
model_name = litellm.utils.remove_model_id(litellm_params["model"]) | ||
|
||
if model_name in litellm.all_embedding_models: | ||
continue # Skip embedding models | ||
|
||
|
||
models_to_check.append(model) | ||
|
||
|
||
healthy_endpoints, unhealthy_endpoints = await _perform_health_check(model_list) | ||
|
||
return healthy_endpoints, unhealthy_endpoints | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of this
logger