fix typos & add missing names for azure models #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
requested changes
Jan 1, 2024
ishaan-jaff
requested changes
Jan 1, 2024
There was a problem hiding this comment.
Can you update this mapping here too:
Line 337 in ca40a88
since we're calling it azure/gpt-35-turbo now
|
lgtm - just one change requested |
@ishaan-jaff updated 👍 |
ishaan-jaff
approved these changes
Jan 1, 2024
|
Great work @fcakyon! |
Yes its ready to merge @ishaan-jaff ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291
Before this PR, most Azure OpenAI models used incorrect context size in LiteLMM. (For instance,
.is not allowed in Azure deployment names, sogpt-3.5in Openai has to be spelled asgpt-35in Azure OpenAI)This PR makes LiteLMM work perfectly fine with all available Azure OpenAI models.