Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): platforms input #2060

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix(ci): platforms input #2060

merged 2 commits into from
Feb 19, 2024

Conversation

adrien-f
Copy link
Contributor

Hello!

As far as I can tell, the expected input is platforms instead of platform. This give the following warning for example:

In https://github.com/BerriAI/litellm/actions/runs/7946778613/job/21694888088:

Warning: Unexpected input(s) 'platform', valid inputs are ['add-hosts', 'allow', 'attests', 'build-args', 'build-contexts', 'builder', 'cache-from', 'cache-to', 'cgroup-parent', 'context', 'file', 'labels', 'load', 'network', 'no-cache', 'no-cache-filters', 'outputs', 'platforms', 'provenance', 'pull', 'push', 'sbom', 'secrets', 'secret-files', 'shm-size', 'ssh', 'tags', 'target', 'ulimit', 'github-token']

This should restore multi platform images 👍

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:22pm
litellm-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:22pm

@ishaan-jaff
Copy link
Contributor

LGTM - thanks for this fix ⭐️

I was confused when debugging this issue

@ishaan-jaff
Copy link
Contributor

@adrien-f followed up with you on Linkedin to start a 1:1 support channel for LiteLLM

@ishaan-jaff ishaan-jaff merged commit 9ba9d21 into BerriAI:main Feb 19, 2024
2 checks passed
@ishaan-jaff
Copy link
Contributor

@adrien-f ran this PR to deploy and it failed: https://github.com/BerriAI/litellm/actions/runs/7962195281/job/21735111116
Can we get your help debugging ?

ERROR: Multi-platform build is not supported for the docker driver.
Switch to a different driver, or turn on the containerd image store, and try again.
Learn more at https://docs.docker.com/go/build-multi-platform/
Error: buildx failed with: Learn more at https://docs.docker.com/go/build-multi-platform/

@adrien-f
Copy link
Contributor Author

Ah so it was not as easy as only this flag :') Let me see what I can find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants