-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude /docs to reduce Docker image size #2534
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Awesome PR - this will really help our docker builds |
Can you also ignore
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also ignore
cookbook
.circleci
.github
tests
@ishaan-jaff, I've updated the PR to include the additional directories. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last request before merging - can you run a docker build
+ docker run
with these changes. Just to ensure litellm builds correctly ?
@ishaan-jaff, I've successfully executed the Docker build and run as per the last request. During this process, an issue was encountered, which seems related to configuration settings external to our |
Awesome ! |
Thank you very much for giving this opportunity to contribute ❤️ |
This PR introduces a
.dockerignore
file with an entry to exclude the/docs
directory from Docker builds. By doing so, it aims to reduce the Docker image size, leading to improved build performance and efficiency.