Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude /docs to reduce Docker image size #2534

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

Hitro147
Copy link
Contributor

This PR introduces a .dockerignore file with an entry to exclude the /docs directory from Docker builds. By doing so, it aims to reduce the Docker image size, leading to improved build performance and efficiency.

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 3:55pm

@ishaan-jaff
Copy link
Contributor

Awesome PR - this will really help our docker builds

@ishaan-jaff
Copy link
Contributor

Can you also ignore

  • cookbook
  • .circleci
  • .github
  • tests

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also ignore

cookbook
.circleci
.github
tests

@Hitro147
Copy link
Contributor Author

@ishaan-jaff, I've updated the PR to include the additional directories. Thanks!

@Hitro147 Hitro147 requested a review from ishaan-jaff March 15, 2024 16:03
Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last request before merging - can you run a docker build + docker run with these changes. Just to ensure litellm builds correctly ?

@Hitro147
Copy link
Contributor Author

@ishaan-jaff, I've successfully executed the Docker build and run as per the last request. During this process, an issue was encountered, which seems related to configuration settings external to our .dockerignore adjustments. Specifically, it appears tied to the setup of necessary API credentials. Other than this all seems in order with the changes made.

image

@Hitro147 Hitro147 requested a review from ishaan-jaff March 15, 2024 16:26
@ishaan-jaff ishaan-jaff merged commit 04517b0 into BerriAI:main Mar 15, 2024
2 checks passed
@ishaan-jaff
Copy link
Contributor

Awesome !

@Hitro147
Copy link
Contributor Author

Thank you very much for giving this opportunity to contribute ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants