Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(oidc): Add support for loading tokens via a file, env var, and path in env var #5251

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

Manouchehri
Copy link
Collaborator

@Manouchehri Manouchehri commented Aug 16, 2024

Title

Adds oidc/env/{env_var_name}, oidc/file/{temp_file_path}, and oidc/env_path/{env_var_name} support for OIDC flows.

Relevant issues

Personally, I really recommend using stuff like oidc/azure/ instead, as that allows us to update it in the future if Azure ever changes their API..

That said, PRs like #5131 show that people seem to really want to set their own custom OIDC variables, even if LiteLLM already supports their use-case.

There are some valid edge use-cases where I can see this being required. Everyone else reading this, should really use the oidc/[provider]/[?audience] format unless you have a good reason not to.

Type

🆕 New Feature
📖 Documentation
✅ Test

Changes

Adds support for using oidc/env/{env_var_name}, oidc/file/{temp_file_path}, and oidc/env_path/{env_var_name}, and

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:32pm

@krrishdholakia krrishdholakia merged commit 6b1be47 into BerriAI:main Aug 17, 2024
3 checks passed
@krrishdholakia
Copy link
Contributor

Thanks for this @Manouchehri

@Manouchehri
Copy link
Collaborator Author

Do let me know if any unit tests break on this in the future; I don't expect that to happen, but I'd be happy to fix it if it does. :)

@krrishdholakia
Copy link
Contributor

ci/cd looks smooth so far - thanks for the offer, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants