Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub Action to automatically build docker images #655

Merged
merged 10 commits into from
Oct 20, 2023

Conversation

coconut49
Copy link
Contributor

Hi there,

I wanted to let you know that this PR is essentially the same as #634. However, I regret to inform you that I had misconfigured the Github Pull App, which caused the changes to be purged by the Pull Bot before the code merge. I have since removed the Bot and am resubmitting the code once more.

Would it be possible for you to create a docker build in GitHub Action after the code merge? It would be greatly appreciated.

Thank you.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 4:27am

@krrishdholakia
Copy link
Contributor

Hey @coconut49 what does

create a docker build in GitHub Action

mean?

@coconut49
Copy link
Contributor Author

Hi @krrishdholakia Could you kindly navigate to https://github.com/BerriAI/litellm/actions/workflows/docker.yml and click on the Run workflow button, please? Because I'm not a maintainer, I don't have access to trigger workflows.

image

@SlapDrone
Copy link
Contributor

+1 here, would be great if y'all published the package @krrishdholakia! 😄

@krrishdholakia
Copy link
Contributor

done @coconut49
Screenshot 2023-10-20 at 11 33 42 AM

@SlapDrone / @coconut49 any help understanding why y'all are doing this would be great, so we can actually make this better for your use-case.

attaching my calendly, even a 10 minute chat on this would help a lot - https://calendly.com/d/4mp-gd3-k5k/litellm-1-1-onboarding-chat.

@krrishdholakia
Copy link
Contributor

fyi - @coconut49 @SlapDrone there was an issue with the build

Screenshot 2023-10-20 at 12 11 54 PM

@krrishdholakia
Copy link
Contributor

what's the right naming scheme for docker images?

@krrishdholakia
Copy link
Contributor

cc: @ishaan-jaff i think you've worked on this

@SlapDrone
Copy link
Contributor

what's the right naming scheme for docker images?

@krrishdholakia lowercase (berriai) and I think typically for ghcr the tag should match the branch, so main, but I am not an expert on ghcr, so perhaps it's possible to change this behaviour.

done @coconut49 Screenshot 2023-10-20 at 11 33 42 AM

@SlapDrone / @coconut49 any help understanding why y'all are doing this would be great, so we can actually make this better for your use-case.

attaching my calendly, even a 10 minute chat on this would help a lot - https://calendly.com/d/4mp-gd3-k5k/litellm-1-1-onboarding-chat.

Sorry I am in the absolute worst time zone for this haha!

But hopefully it's simple enough: At least for me the use-case is literally just to be able to pull (an up-to-date) litellm directly from a docker repository (i.e. docker pull ghcr.io/.../litellm:main) rather than clone this repo and build the image locally. This means I can just have litellm set up for example as a service in a docker-compose file.

@krrishdholakia
Copy link
Contributor

@SlapDrone thanks.

What does:

litellm set up for example as a service in a docker-compose file.
mean?

Is this our simple-proxy that you're trying to spin up? https://github.com/BerriAI/litellm/tree/main/openai-proxy?

@krrishdholakia
Copy link
Contributor

Hey @coconut49 @SlapDrone got an image deployed - https://github.com/orgs/BerriAI/packages/container/package/litellm

Will formalize this into a proper workflow

@coconut49
Copy link
Contributor Author

what's the right naming scheme for docker images?

@krrishdholakia lowercase (berriai) and I think typically for ghcr the tag should match the branch, so main, but I am not an expert on ghcr, so perhaps it's possible to change this behaviour.

done @coconut49 Screenshot 2023-10-20 at 11 33 42 AM
@SlapDrone / @coconut49 any help understanding why y'all are doing this would be great, so we can actually make this better for your use-case.
attaching my calendly, even a 10 minute chat on this would help a lot - https://calendly.com/d/4mp-gd3-k5k/litellm-1-1-onboarding-chat.

Sorry I am in the absolute worst time zone for this haha!

But hopefully it's simple enough: At least for me the use-case is literally just to be able to pull (an up-to-date) litellm directly from a docker repository (i.e. docker pull ghcr.io/.../litellm:main) rather than clone this repo and build the image locally. This means I can just have litellm set up for example as a service in a docker-compose file.

Hi @krrishdholakia I have merged the #678 . Can you try to create a docker build in GitHub Action again?

@SlapDrone
Copy link
Contributor

+1, will be super nice to get the CI pipeline publishing packages regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants