Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiteLLM Common Base LLM Config (pt.4): Move Ollama to Base LLM Config #7157

Merged
merged 5 commits into from
Dec 11, 2024
Merged

LiteLLM Common Base LLM Config (pt.4): Move Ollama to Base LLM Config #7157

merged 5 commits into from
Dec 11, 2024

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Dec 11, 2024 •
edited
Loading

Title

Move Ollama to Common Base LLM Config

Relevant issues

Addresses feedback from andrewyng/aisuite#113 (comment)

Type

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Changes

[REQUIRED] Testing - Attach a screenshot of any new tests passing locall

If UI changes, send a screenshot/GIF of working UI fixes

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 5:37am

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 82.88288% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
litellm/llms/ollama/completion/transformation.py 84.04% 15 Missing ⚠️
litellm/llms/ollama/completion/handler.py 50.00% 3 Missing ⚠️
litellm/llms/ollama/common_utils.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@krrishdholakia krrishdholakia changed the title Litellm ollama refactor LiteLLM Common Base LLM Config (pt.4): Move Ollama to Base LLM Config Dec 11, 2024
@krrishdholakia krrishdholakia merged commit 40a22eb into main Dec 11, 2024
5 of 25 checks passed
@krrishdholakia krrishdholakia deleted the litellm_ollama_refactor branch December 11, 2024 05:39
@krrishdholakia krrishdholakia restored the litellm_ollama_refactor branch December 11, 2024 05:39
@krrishdholakia krrishdholakia mentioned this pull request Dec 11, 2024
Merged
rajatvig pushed a commit to rajatvig/litellm that referenced this pull request Jan 16, 2025
@krrishdholakia @rajatvig
LiteLLM Common Base LLM Config (pt.4): Move Ollama to Base LLM Config (…
a4c6fb2 
…BerriAI#7157)

* refactor(ollama/): refactor ollama `/api/generate` to use base llm config

Addresses andrewyng/aisuite#113 (comment)

* test: skip unresponsive test

* test(test_secret_manager.py): mark flaky test

* test: fix google sm test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krrishdholakia