Add functionality to automatic check the addition of all primary key … #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields to the table fields and avoid disabling PK fields for the export.
Bertverbeek4PS
approved these changes
Nov 20, 2024
|
@acjdekorte thanks for the addition! Indeed I thnk this is a good idea to always export the primary key. |
|
@Bertverbeek4PS Thank you for accepting this pullrequest. You are aware that this caused the automatic test to fail, since the new import now contained more fields (to be more precise the code field of reason code table)? |
Yes indeed. I will need to look add those tests again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently added the functionality to ensure the addition of the primary key fields on table export. We have performed this since we running into problems with our azure data factory when not all primary key fields were present on the table export. Additionally we highlighted the Index fields in the list of fields.
We think that this might be a nice addition to the community version as well.