Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: fix SOA #1384

Merged
merged 3 commits into from
Dec 23, 2024
Merged

DNS: fix SOA #1384

merged 3 commits into from
Dec 23, 2024

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Dec 23, 2024

closes #1379

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit f28a74b
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/676961f4a1617a0008397765

Copy link

codecov bot commented Dec 23, 2024

Bundle Report

Bundle size has no change ✅

@BeryJu BeryJu changed the title DNS: fix soa DNS: fix SOA Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (56874b8) to head (f28a74b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
pkg/roles/dns/api_zones.go 0.00% 4 Missing ⚠️
pkg/roles/dns/handler_int_soa.go 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   59.72%   60.05%   +0.32%     
==========================================
  Files         136      137       +1     
  Lines        7626     7640      +14     
==========================================
+ Hits         4555     4588      +33     
+ Misses       2627     2605      -22     
- Partials      444      447       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 48c92ff into main Dec 23, 2024
18 checks passed
@BeryJu BeryJu deleted the dns/fix-soa branch December 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOA Record Resolution not occurring as expected
1 participant