Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem setting git username/email with GH_PAT only #168

Closed
ndom91 opened this issue Feb 13, 2022 · 14 comments Β· Fixed by #287
Closed

Problem setting git username/email with GH_PAT only #168

ndom91 opened this issue Feb 13, 2022 · 14 comments Β· Fixed by #287
Labels
bug Something isn't working released waiting for response Waiting for a response from the author

Comments

@ndom91
Copy link

ndom91 commented Feb 13, 2022

🐞 Describe the bug

Our sync action stopped working ~5 days ago (seemingly after this was merged - #153). Throwing an error that the git username/email was missing.

We're passing only a GH_PAT, not an installation token.

πŸ–ΌοΈ Screenshots

image

See last working run: https://github.com/nextauthjs/next-auth/actions/runs/1809749953
Failing run: https://github.com/nextauthjs/next-auth/actions/runs/1815281481

πŸ“‹ Additional context

Sync action: https://github.com/nextauthjs/next-auth/blob/main/.github/workflows/sync-example.yml
Sync config: https://github.com/nextauthjs/next-auth/blob/main/.github/sync.yml

@ndom91 ndom91 added the bug Something isn't working label Feb 13, 2022
balazsorban44 added a commit to nextauthjs/next-auth that referenced this issue Feb 14, 2022
@BetaHuhn
Copy link
Owner

Hi @ndom91, thanks for reporting this!

I will take a look and get this fixed asap.

@BetaHuhn
Copy link
Owner

I can't seem to reproduce your issue. I tried running the action with only the GH_PAT and it is working without any errors (see the test run).

Could you enable the step debug logging by setting the ACTIONS_STEP_DEBUG secret to true and try again? It should print that it is setting the git username and email.

@ndom91
Copy link
Author

ndom91 commented Feb 14, 2022

I can't seem to reproduce your issue. I tried running the action with only the GH_PAT and it is working without any errors (see the test run).

Could you enable the step debug logging by setting the ACTIONS_STEP_DEBUG secret to true and try again? It should print that it is setting the git username and email.

Thanks for taking a look! We'll give that a try and get back to you.

Cc: @balazsorban44

@balazsorban44
Copy link
Contributor

balazsorban44 commented Feb 15, 2022

Yes, we can try that.

I got 404 on your test run, by the way. Is it a hidden repository you link to?

FWIW, pinning down to the previous version worked:

https://github.com/nextauthjs/next-auth/actions/runs/1838645699

nextauthjs/next-auth@1c2b573

@BetaHuhn
Copy link
Owner

I got 404 on your test run, by the way. Is it a hidden repository you link to?

Whoops, yeah it was set to private. Fixed now.

@BetaHuhn
Copy link
Owner

Just checking in, is the issue still coming up? @balazsorban44 @ndom91

@BetaHuhn BetaHuhn added the waiting for response Waiting for a response from the author label Mar 13, 2022
@BetaHuhn
Copy link
Owner

BetaHuhn commented May 5, 2022

Closing this for now. Please reopen it if the issue persists.

@BetaHuhn BetaHuhn closed this as completed May 5, 2022
@aehlke
Copy link

aehlke commented Jun 14, 2022

I'm experiencing this issue on latest

@SignorMercurio
Copy link

Also experiencing this issue on latest, using GH_PAT only with the same error message.

@BetaHuhn BetaHuhn reopened this Aug 13, 2022
@JBG-brad
Copy link

I'm experiencing this issue on latest as of 10/23/2022

@aFlyBird0
Copy link

Same on 01/12/2022πŸ₯Ή

@balazsorban44
Copy link
Contributor

balazsorban44 commented Jan 7, 2023

Unfortunately, this is still an issue. πŸ˜• I hoped that #268 would have fixed it, but as you can see, it still has the same issue:

Failed run: https://github.com/nextauthjs/next-auth/actions/runs/3861126802/jobs/6581905236
Config: https://github.com/nextauthjs/next-auth/blob/main/.github/sync.yml
Workflow: https://github.com/nextauthjs/next-auth/blob/main/.github/workflows/sync-examples.yml
Token access:
image

I even tried manually defining GIT_EMAIL and GIT_USERNAME (which according to the docs should not be needed for a Personal Access Token setup) but it still fails: https://github.com/nextauthjs/next-auth/actions/runs/3861147118/jobs/6581937514

@balazsorban44
Copy link
Contributor

balazsorban44 commented Jan 7, 2023

After some trial and error, I think it's related to the deleteOrphaned: true option:

Works: https://github.com/nextauthjs/next-auth/actions/runs/3861270527/jobs/6582142581
Does not work: https://github.com/nextauthjs/next-auth/actions/runs/3861292840/jobs/6582183058

It messes up the .git folder.

@BetaHuhnBot
Copy link
Collaborator

πŸŽ‰ This issue has been resolved in version 1.19.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released waiting for response Waiting for a response from the author
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants