feat: add templating support #201
Conversation
| @@ -123,7 +123,7 @@ class Git { | |||
| async createPrBranch() { | |||
| const prefix = BRANCH_PREFIX.replace('SOURCE_REPO_NAME', GITHUB_REPOSITORY.split('/')[1]) | |||
|
|
|||
| let newBranch = path.join(prefix, this.repo.branch).replace(/\\/g, '/') | |||
| let newBranch = path.join(prefix, this.repo.branch).replace(/\\/g, '/').replace(/\/\./g, '/') | |||
| return true | ||
| } | ||
|
|
||
| await fs.copy(src, dest, exclude !== undefined && { filter: filterFunc }) | ||
| await fs.copy(src, dest, { filter: filterFunc }) |
There was a problem hiding this comment.
We check for exclude !== undefined inside filterFunc
|
Hey @erezrokah, first of all, thanks for taking the time to contribute to this project! Next time, could you explain what your changes are trying to achieve in the PR body? This makes it easier for me as a maintainer to get an overview without me having to go through your changes one by one and having to piece everything together myself. I think templating support could be useful and I would like to include it in this action, but I am not sure if your current syntax is the right way to go about it. Specifically, I don't like the way you need to specify files to use as data for the templates: I created a discussion about this topic where we can discuss how we implement this feature before moving to the actual code. I want to hear about more use cases before finalizing a syntax. Happy to revisit your idea if you explain your reasoning a bit more. Feel free to comment your ideas in the discussion! Thanks :) |
|
Thank you for commenting @BetaHuhn and I appreciate the time you spent going through the PR. I'll definitely add more details next time 🤦 Happy to close the PR and continue this in the discussion 👍 |
Hi 👋
It's me again, from this PR #200
Opening as draft to get some feedback.