Include response body to exception message #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It eases debugging,
Example of exception message:
com.bettercloud.vault.VaultException: Expecting HTTP status 204 or 200, but instead receiving 403
Response body: {"errors":["permission denied"]}
|
This looks great, thanks! But in the process of merging an earlier PR, a merge conflict resulted for this one. If you could please resolve it, then I'd be happy to merge. |
|
Done. |
|
Thanks so much! |
jentfoo
pushed a commit
to jentfoo/vault-java-driver
that referenced
this pull request
Jun 13, 2019
Lease endpoints
mikegrass
added a commit
to mikegrass/vault-java-driver
that referenced
this pull request
Dec 5, 2019
Similar to BetterCloud#49, it including the response body in the exception thrown for auth failures provides information that is helpful for debugging failed logins. Add the response body to the VaultException thrown when an Auth method fails.
mikegrass
added a commit
to mikegrass/vault-java-driver
that referenced
this pull request
Dec 5, 2019
Similar to BetterCloud#49, including the response body in the exception thrown for auth failures provides information that is helpful for debugging failed logins. Add the response body to the VaultException thrown when an Auth method fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status code isn't sufficient to understand the error in some cases,
so I made this patch to include response body to exception message.
Examples of exception message:
Closes #47