Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting editor with symbol #492

Merged

Conversation

srachner
Copy link
Contributor

@srachner srachner commented Nov 5, 2020

The changes in commit 6591cf9 broke setting an editor with a symbol, when the method Editor.for_symbol was renamed to Editor.editor_from_symbol.

@coveralls
Copy link

coveralls commented Nov 5, 2020

Pull Request Test Coverage Report for Build 347414729

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.838%

Totals Coverage Status
Change from base Build 346475882: 0.0%
Covered Lines: 490
Relevant Lines: 506

💛 - Coveralls

@BetterErrors BetterErrors deleted a comment from coveralls Nov 5, 2020
@RobinDaugherty
Copy link
Member

RobinDaugherty commented Nov 5, 2020

Thank you! This should have been caught by rspec-mock! I'll cut a release for this right away and then investigate further.

@RobinDaugherty RobinDaugherty merged commit fce143f into BetterErrors:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants