Use SASS to build CSS #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 418192634
💛 - Coveralls |
inulty-dfe
added a commit
to DFE-Digital/publish-teacher-training
that referenced
this pull request
Jul 12, 2023
The gem was added because the 2.10.1 release of better_errors broke the build. A new release 2.10.1 fixed the issue and SASSC is no longer needed in the application. The css is compiled and included in the built gem. Breaking Change: BetterErrors/better_errors#498 Fix: BetterErrors/better_errors#520
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow more productivity when developing CSS changes. In development, the scss is compiled without compression and including line comments to help with development.
By moving the block of CSS out of
main.erb, the file is reduced by a substantial amount, which should make development a bit easier as well.When the gem is built (in CI),
main.cssis built with the compressed CSS and included in the gem. The scss files are not included in the gem.