Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated #4

PEZ · 2022-04-28T16:50:06Z

I want to be able to load a script file in the repl without some things getting evaluated, and have those evaluated if the script is being run.

Something like:

(ns something ...)

(defn some-fn-that-should-only-be-called-when-script-run []
  ...)

(when-not *repl-eval?*
  (some-fn-that-should-only-be-called-when-script-run))

And I'd like to take a stab at this. 😄

borkdude · 2022-04-28T16:52:55Z

@PEZ I think it's good to ask ourselves: how can we support this without adding options. Are there any existing solutions around that Clojure users are already familiar with? Why is there no such a thing in Clojure proper? Etc.

borkdude · 2022-04-28T16:55:43Z

E.g. one solution that already just works in user space is:

(def dev? true)

(when-not dev?
  ...)

PEZ · 2022-04-28T19:19:11Z

Yes, there are probably much better alternatives. I am not really floating solution ideas here, more the need. The ”idea”, insofar there is one, was inspired by how I use Babashka.

One solution would be to do the same as with Babashka. I.e. set *file* when it is run as a script, but not when loaded in the REPL. (Though, you told me offline that dynamic vars might not fit in this execution context, but anyway.)

Why is there no such a thing in Clojure proper?

I think it is because it was not designed as a scripting language.

PEZ · 2022-04-28T19:20:16Z

I solved my use case for now like so:

(ns ignore-form
  (:require ["vscode" :as vsode]
            [promesa.core :as p]
            [z-joylib.vscode-utils :as vsu]))

(defonce run-main? true)

(comment
  ;; Loading this in the REPL w/o evaluating `main`:
  (defonce run-main? false)  ; <- First evaluate this
  (ns-unmap *ns* 'run-main?) ; <- Evaluate this when you are done
                             ;    or want to test-run the script
  )

(defn main []
  (p/let [editor ^js vscode/window.activeTextEditor
          original-selection (vsu/current-selection)
          _ (vscode/commands.executeCommand "paredit.backwardUpSexp")
          insert-position (.-active (vsu/current-selection))]
    (aset editor "selection" original-selection)
    (p/do! (vsu/insert-text!+ "#_" editor insert-position))))

(when run-main?
  (main))

(comment  
  (main)
  )

borkdude · 2022-04-28T19:28:53Z

I.e. set file when it is run as a script, but not when loaded in the REPL.

Depending on how the nREPL implementation works, that might already be true.

For nbb there is a similar issue: babashka/nbb#95

The way it's phased there is "detect the invoked script", I think that might be a better way to describe the problem.

The solution there looks as follows:

(= nbb.core/*file* (:file (meta #'init)))

which says: is the file that's currently being executed, the same as where one of the functions in this namespace is defined?

I don't think *file* is being set at all currently which might be a nice thing to fix first if you want :).

PEZ · 2022-04-28T19:33:55Z

Depending on how the nREPL implementation works, that might already be true.

First thing I tried. 😄 Didn't work. Could be that I didn't check it properly. Now that I try it I see that I have an error:

SyntaxError: Invalid regular expression: /*file*/: Nothing to repeat
    at new RegExp (<anonymous>)
    at Object.cljs$core$re_pattern [as re_pattern] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:10181:5)
    at Object.joyride$repl_utils$match [as match] (/Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/repl_utils.cljs:22:13)
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/repl_utils.cljs:103:38
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:4441:22
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:4442:15
    at Object.sval (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3456:18)
    at Object.cljs$core$ISeqable$_seq$arity$1 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3446:1)
    at Object.cljs$core$seq [as seq] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1236:13)
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3811:15
    at Object.sval (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3456:18)
    at Object.cljs$core$ISeqable$_seq$arity$1 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3446:1)
    at Object.cljs$core$seq [as seq] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1236:13)
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:4750:18
    at Object.sval (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3456:18)
    at Object.cljs$core$ISeqable$_seq$arity$1 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3446:1)
    at Object.cljs$core$seq [as seq] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1236:13)
    at Function.cljs$core$IFn$_invoke$arity$3 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1866:28)
    at Function.cljs$core$IFn$_invoke$arity$3 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1936:10)
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:9531:21
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/cljs.core.js:30971:3
    at Object.sval (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3456:18)
    at Object.cljs$core$ISeqable$_seq$arity$1 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3446:1)
    at Object.cljs$core$seq [as seq] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:1236:13)
    at Function.cljs$core$IFn$_invoke$arity$3 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:2497:26)
    at Object.cljs$core$IReduce$_reduce$arity$3 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:3523:28)
    at Function.cljs$core$IFn$_invoke$arity$3 (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:2569:17)
    at Object.cljs$core$vec [as vec] (/Users/pez/Projects/joyride/out/js/cljs-runtime/cljs/core.cljs:5755:7)
    at Object.joyride$repl_utils$handle_complete_STAR_ [as handle_complete_STAR_] (/Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/repl_utils.cljs:106:29)
    at joyride$nrepl$handle_complete (/Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:123:20)
    at joyride$nrepl$handle_request (/Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:139:6)
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:31:6
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:47:6
    at /Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:37:6
    at Socket.<anonymous> (/Users/pez/Projects/joyride/out/js/cljs-runtime/joyride/nrepl.cljs:176:14)
    at Socket.emit (/Users/pez/Projects/joyride/lib/events.js:390:28)
    at addChunk (/Users/pez/Projects/joyride/lib/internal/streams/readable.js:315:12)
    at readableAddChunk (/Users/pez/Projects/joyride/lib/internal/streams/readable.js:289:9)
    at Socket.push (/Users/pez/Projects/joyride/lib/internal/streams/readable.js:228:10)
    at TCP.onStreamRead (/Users/pez/Projects/joyride/lib/internal/stream_base_commons.js:199:23)
    at TCP.callbackTrampoline (node:internal/async_hooks:130:17) {stack: 'SyntaxError: Invalid regular expression: /*fi…Trampoline (node:internal/async_hooks:130:17)', message: 'Invalid regular expression: /*file*/: Nothing to repeat'}

borkdude · 2022-04-28T19:34:55Z

@PEZ It looks like you copy pasted from markdown ;)

PEZ · 2022-04-28T19:37:14Z

It looks like you copy pasted from markdown ;)

Please elaborate, I want to understand the joke. 😄

borkdude · 2022-04-28T19:41:57Z

I see /*file*/ in your error which seems markdown for marking up *file* in cursive.

PEZ · 2022-05-01T10:30:23Z

Follow up on comments on #18:

Hmm... So not for this PR, but thinking about how to solve #4:

In babashska I do things like:

(let [run-script? (= *file* (System/getProperty "babashka.file")) ...])

Where the babashka.file property is nil on nREPL load-file, but the script file name when run by bb.

I like that pattern (think I picked it up from the Babashka book). What would a Joyride equivalent be?

borkdude · 2022-05-01T10:32:24Z

I think that would be a function: (joyride.core/invoked-script)

PEZ · 2022-05-01T10:35:22Z

Awesome. You have suggested that elsewhere. Now I understand it. 😄

Fixes #4

PEZ added the repl label Apr 28, 2022

PEZ self-assigned this Apr 28, 2022

PEZ changed the title ~~Some way to check if it's the REPL that evaluating or a script being run~~ Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated Apr 28, 2022

PEZ linked a pull request May 1, 2022 that will close this issue

Add joyride.core namespace w/ *file* #18

Merged

PEZ mentioned this issue May 1, 2022

Add joyride.core namespace w/ *file* #18

Merged

PEZ removed a link to a pull request May 1, 2022

Add joyride.core namespace w/ *file* #18

Merged

PEZ added a commit that referenced this issue May 8, 2022

Add joyride.core/get-invoked-script

57efc38

Fixes #4

PEZ mentioned this issue May 8, 2022

Add joyride.core/get-invoked-script #39

Merged

PEZ closed this as completed in #39 May 9, 2022

PEZ added a commit that referenced this issue May 9, 2022

Add joyride.core/get-invoked-script (#39)

9673621

Fixes #4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated #4

Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated #4

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022 •

edited

Loading

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented May 1, 2022

borkdude commented May 1, 2022

PEZ commented May 1, 2022

Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated #4

Load a script file in the repl without some things getting evaluated, but when the script is run they should be evaluated #4

Comments

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022 • edited Loading

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented Apr 28, 2022

borkdude commented Apr 28, 2022

PEZ commented May 1, 2022

borkdude commented May 1, 2022

PEZ commented May 1, 2022

PEZ commented Apr 28, 2022 •

edited

Loading