Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*file* is not being set #5

Closed
PEZ opened this issue Apr 28, 2022 · 1 comment · Fixed by #18
Closed

*file* is not being set #5

PEZ opened this issue Apr 28, 2022 · 1 comment · Fixed by #18

Comments

@PEZ
Copy link
Collaborator

PEZ commented Apr 28, 2022

The *file* variable is not yet set by Joyride when running scripts.
@borkdude
Copy link
Collaborator

In CLJS there is no *file*. Using *file* without a namespace context in CLJS will give a warning in clj-kondo. Therefore I opted in nbb to create a separate namespace nbb.core with *file* dynamic var in it. I propose we do the same in joyride:

joyride.core/*file*

@PEZ PEZ changed the title *file* os not being set *file* is not being set Apr 29, 2022
PEZ added a commit that referenced this issue Apr 30, 2022
@PEZ
Add joyride.core namespace w/ *file*
3937e38 
Fixes: #5
@PEZ PEZ mentioned this issue Apr 30, 2022
Merged
borkdude pushed a commit that referenced this issue May 1, 2022
@PEZ
Add joyride.core namespace w/ *file* (#18)
6e0fd40 
* Add joyride.core namespace w/ *file*

Fixes: #5

* Update changelog

* Rename sci aliases

* Make nrepl load-file set  `joyride.core*file*`

* Reset ignore-form example

* Use assoc instead of merge

* Add docs about `joyride.core`

* Added missing `promesa.core` symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add joyride.core namespace w/ *file* BetterThanTomorrow/joyride
2 participants
@PEZ @borkdude