More proper run code command and fix dev reloadability #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command for running a piece of code was named
runScript
, which implied it worked similar to the runWorkspaceScript command, which it doesn't. It prompted for the user to input code, and disregarded any argument. The result of evaluating the code was then alerted, causing noice in the UI.The command is now renamed. to
runCode
and will evaluate the argument, if handed one, as code. And without any argument it will prompt for code, as before. The results are printed in the Joyride output channel, where it can be copied to the clipboard, or whatever.While doing this work, I noticed I was losing the output channel reference when I saved the file. Which was because the
!db
item wasdef
ed instead ofdefonce
ed. I decided to put in a proper lifecycle managament with shadow-cljs:before
and:after
hooks. And I also wanted to be able to ”reactivate” the extension w/o restart so I fixed that too, and made it happen on shadow-cljs reload.