Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2.2 upgrade #27

Merged
merged 8 commits into from
Sep 29, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, 3.0, 3.1]
ruby: [3.0, 3.1, 3.2]
gemfile:
- Gemfile

Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ require:

AllCops:
NewCops: enable
TargetRubyVersion: 2.7
TargetRubyVersion: 3.0
11 changes: 10 additions & 1 deletion .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 99999 --no-auto-gen-timestamp`
# using RuboCop version 1.56.0.
# using RuboCop version 1.56.4.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -49,6 +49,15 @@ Performance/MapMethodChain:
Exclude:
- 'lib/rubocop/cop/betterment/server_error_assertion.rb'

# Offense count: 3
# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
# Include: **/*_spec*rb*, **/spec/**/*
RSpec/FilePath:
Exclude:
- 'spec/rubocop/cop/betterment/utils/hardcoded_attribute_spec.rb'
- 'spec/rubocop/cop/betterment/utils/method_return_table_spec.rb'
- 'spec/rubocop/cop/betterment/utils/parser_spec.rb'
argvniyx-enroute marked this conversation as resolved.
Show resolved Hide resolved

# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
Rails/NegateInclude:
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.6
3.2.2
2 changes: 1 addition & 1 deletion betterlint.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |s|

s.files = Dir["README.md", "STYLEGUIDE.md", "config/*.yml", "lib/**/*.rb"]

s.required_ruby_version = ">= 2.7"
s.required_ruby_version = ">= 3.0"

s.add_dependency "rubocop", "> 1.0"
s.add_dependency "rubocop-performance"
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/cop/betterment/unscoped_find.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class UnscopedFind < Cop
See here for more information on this error:
https://github.com/Betterment/betterlint/blob/main/README.md#bettermentunscopedfind
MSG
METHOD_PATTERN = /^find_by_(.+?)(!)?$/.freeze
METHOD_PATTERN = /^find_by_(.+?)(!)?$/
FINDS = %i(find find_by find_by! where).freeze

def_node_matcher :custom_scope_find?, <<-PATTERN
Expand Down