Detect references to ENV outside of config directories #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
woaow this is a great idea! gonna take a peek 🙂 |
6f6d6172
previously approved these changes
Feb 6, 2025
There was a problem hiding this comment.
domain lgtm, it all looks straightforward to me. only thing I would consider is a more precise name over Betterment/Environment, but I don't feel strongly enough about it to block.
what's your plan to roll this out? we use ENV in a lot of places, in models and controllers and their specs, etc
|
The plan is to:
|
smudge
reviewed
Feb 6, 2025
README.md
Outdated
| @@ -130,6 +130,27 @@ end | |||
| ``` | |||
|
|
|||
| All three `params.permit` calls will be flagged. | |||
|
|
|||
| ### Betterment/Environment | |||
There was a problem hiding this comment.
Suggested change
| ### Betterment/Environment | |
| ### Betterment/EnvironmentConfiguration |
If you're looking for a slightly more descriptive name.
betterment-policy-bot-production
bot
dismissed
6f6d6172’s stale review
Invalidated by push of 05f9eee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cop will report references to
ENVin files outside of the config directory.The idea is that applications should extract variables from the ENV at boot time, and fail if those variables are not valid.