Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

[share] Don't nullify method channel's call handler when detached from Activity #1

Merged
mduong merged 1 commit into from
Jun 18, 2020
Merged

[share] Don't nullify method channel's call handler when detached from Activity #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/share/android/src/main/java/io/flutter/plugins/share/SharePlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ public void onAttachedToEngine(FlutterPluginBinding binding) {

@Override
public void onDetachedFromEngine(FlutterPluginBinding binding) {
methodChannel.setMethodCallHandler(null);
methodChannel = null;
share = null;
tearDownChannel();
}

@Override
Expand All @@ -44,7 +42,7 @@ public void onAttachedToActivity(ActivityPluginBinding binding) {

@Override
public void onDetachedFromActivity() {
tearDownChannel();
share.setActivity(null);
}

@Override
Expand All @@ -65,7 +63,8 @@ private void setUpChannel(Activity activity, BinaryMessenger messenger) {
}

private void tearDownChannel() {
share.setActivity(null);
methodChannel.setMethodCallHandler(null);
methodChannel = null;
share = null;
}
}