Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jmileham/relax naming validations #116

Merged
merged 2 commits into from
May 5, 2019

Conversation

jmileham
Copy link
Member

@jmileham jmileham commented May 5, 2019

Summary

now that testtrack-cli runs headless, we really can't have server side validations that invalidate otherwise good splits. The test suffix is no longer possible, and the outlaw of the word new was kind of an opinion that really doesn't hold up that well for a company based in new_york. We'll have to find other ways to encourage good split naming.

Thanks for contributing to TestTrack!

/domain @Betterment/test_track_core
/platform @samandmoore @smudge

@nanda-prbot
Copy link

Needs somebody from @Betterment/test_track_core to claim domain review
Needs somebody from @samandmoore and @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

@samandmoore
Copy link
Member

<<domainlgtm platformlgtm

@nanda-prbot
Copy link

Approved! 🌞 ⚡ 🎈

@jmileham jmileham merged commit 746e14e into master May 5, 2019
@jmileham jmileham deleted the jmileham/relax_naming_validations branch May 5, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants