Fixing includes to properly build and set the association.
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asedge
commented
Mar 9, 2023
…izes the `relationship_name`. Also fixed a test that was expecting a thing to be cached but was not ever added to the `includes`... curious how that test was passing before.
asedge
changed the title
includes to properly build and set the associa…includes to properly build and set the association.
JeffLuckett
reviewed
Mar 10, 2023
Yeah, good call. I'll also update the |
…n because our `table_name` may not match the capitalization of the SF relationship field.
…siness rules say it is a `has_one` we will end up with an array of 1. This will guard against that unlikely scenario.
JeffLuckett
reviewed
Mar 10, 2023
| @@ -1,8 +1,17 @@ | |||
| module ActiveForce | |||
| module Association | |||
| class BelongsToAssociation < Association | |||
|
|
|||
| def relationship_name | |||
| options[:relationship_name] || default_relationship_name | |||
JeffLuckett
approved these changes
Mar 14, 2023
JeffLuckett
deleted the
bugfix/fix_includes_so_association_data_is_saved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix
ActiveForce::ActiveQuerywould properly fetch the associated records but would not know how to assign them so referencing the association would result in another query to Salesforce. We added a mapping of Salesforce relation names to the defined association name to accomplish this.