Escape single quotation mark and backslash when quoting string #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffLuckett
previously approved these changes
Apr 10, 2023
JeffLuckett
previously requested changes
Apr 10, 2023
JeffLuckett
suggested changes
Apr 10, 2023
JeffLuckett
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24
Currently implementation improperly escapes the Quotation. It prevents SOQL injection by forcing it into invalid SOQL statement. However, we have use cases where first name of Lead may contain
'. Example:O'DellNote: This does not handle escaping LIKE expression wildcards such as
%and_. This is a cause for concern if there are any user provided fields that does a LIKE type of search. It's possible to add it to gsub to escape those characters to be on the safe side, but it has potential to break existing functionality.